Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for user modifiable installation of mod_systemd and pidfile locations: #1159

Merged
merged 1 commit into from
Aug 13, 2015

Conversation

vamegh
Copy link
Contributor

@vamegh vamegh commented Jul 22, 2015

default_mods.pp --> added use_systemd option, if running a custom build of apache on
centos7, user modifiable boolean option provided

init.pp --> added pidfile and use_systemd option both of which go to params.pp and allow
these values to be set in hiera. changed all osfamily choices for conf_dir
to draw values from the $pidfile variable.

params.pp --> added $use_systemd, by default set to true to mimic original behaviour.
added $pidfile, set to mimic exact same behaviour as used in init.pp,
except now user changeable via hiera.

@tphoney
Copy link
Contributor

tphoney commented Jul 22, 2015

Can you remove the edit to the metadata.json, this will be updated as part of a release.
The release will include many changes. so it may not be a x.y.1 release

@vamegh
Copy link
Contributor Author

vamegh commented Jul 22, 2015

Sure, this should be done now.

@tphoney
Copy link
Contributor

tphoney commented Jul 24, 2015

sorry more stuff, apologies for getting back to this slowly. This will need a readme update and possibly some tests surrounding this new functionality

@vamegh
Copy link
Contributor Author

vamegh commented Jul 24, 2015

Hi, I've updated the readme to include the 2 new options, they are really only options to be passed ideally via hiera, if required. I don't believe tests are necessary, but If you wish to write the tests, feel free. By default it will keep the apache module behaviour exactly the same, it just provides the user with more customisation, especially if using custom built rpms.

@underscorgan
Copy link
Contributor

@vamegh Thanks for the contribution! Looks like we won't need tests for this, but the code will need to be rebased. Thanks!

…le locations.

default_mods.pp --> added use_systemd option, if running a custom build of apache on
                    centos7, user modifiable boolean option provided

init.pp --> added pidfile and use_systemd option both of which go to params.pp and allow
            these values to be set in hiera. changed all osfamily choices for conf_dir
            removed setting the $pidfile variable (now done in params).

params.pp --> added $use_systemd, by default set to true to mimic original behaviour.
              added $pidfile, set to mimic exact same behaviour as used in init.pp,
              except now user changeable via hiera.

updated documentation, to include the 2 new options.
@vamegh
Copy link
Contributor Author

vamegh commented Aug 13, 2015

Hi,

@mhaskel sorry for the delay, It should be rebased now.

tphoney added a commit that referenced this pull request Aug 13, 2015
Add support for user modifiable installation of mod_systemd and pidfile locations:
@tphoney tphoney merged commit c137d26 into puppetlabs:master Aug 13, 2015
@tphoney
Copy link
Contributor

tphoney commented Aug 13, 2015

@vamegh Thanks for the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants