Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if ensure present before including alias module #1102

Merged
merged 1 commit into from
May 20, 2015

Conversation

maneeshmp
Copy link
Contributor

Even when default_ssl_vhosts is false, the value of scriptalias gets defined and vhost resource includes the alias module. To avoid that we need to check the condition if ensure => present before including the alias module.

@maneeshmp
Copy link
Contributor Author

Fixed the test failure.

@igalic
Copy link
Contributor

igalic commented Apr 16, 2015

could you squash those two commits please?

@maneeshmp
Copy link
Contributor Author

I have squashed the two changes into one commit

@igalic
Copy link
Contributor

igalic commented Apr 16, 2015

o_O why is it failing Travis now :(

@maneeshmp
Copy link
Contributor Author

that failure doesn't have to do anything with my change :(

On Thu, Apr 16, 2015 at 3:11 PM, Igor Galić notifications@github.com
wrote:

o_O why is it failing Travis now :(


Reply to this email directly or view it on GitHub
#1102 (comment)
.

Regards
Maneesh

@maneeshmp
Copy link
Contributor Author

rather i mean it doesn't have anything to do with my change. what to do now
?

Thanks,
Maneesh

On Thu, Apr 16, 2015 at 4:59 PM, Maneesh maneeshmp@gmail.com wrote:

that failure doesn't have to do anything with my change :(

On Thu, Apr 16, 2015 at 3:11 PM, Igor Galić notifications@github.com
wrote:

o_O why is it failing Travis now :(


Reply to this email directly or view it on GitHub
#1102 (comment)
.

Regards
Maneesh

Regards
Maneesh

@underscorgan
Copy link
Contributor

@maneeshmp thanks for the contribution! I reran the tests and they worked, so merging!

underscorgan pushed a commit that referenced this pull request May 20, 2015
check if ensure present before including alias module
@underscorgan underscorgan merged commit 18a3338 into puppetlabs:master May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants