MODULES-1784 check for deprecated options and fail when they are unsupported #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@faker- could you add some tests for this? thanks! |
|
@mhaskel added tests with last commit |
underscorgan
pushed a commit
that referenced
this pull request
Feb 26, 2015
MODULES-1784 check for deprecated options and fail when they are unsupported
|
Great, thanks @faker- ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://tickets.puppetlabs.com/browse/MODULES-1784 for more information.
Basically if you specify allow, deny, order or satisfy on a system running Apache 2.4, those options get silently dropped.
With this pull request those manifests would fail and alert the user that they are not using supported options.
Feedback very much welcome.
I tried to solve this in the manifest but failed since $directories can be an array of hashes and I found no way to check for the existence of a key in such a construct.