Hard-coded LogFormat definitions are hard-coded

[skpy]

This module hard-codes the LogFormat names in httpd.conf. That stinks for sites that rely on the X-Forwarded-For header on servers behind a load balancer.

We can use the CustomLog option on a per-vhost setting; but this means that we'd need to declare that option for every single vhost. That stinks, as it introduces a lot of repetition.

It'd be nice if the list of LogFormat definitions in httpd.conf could be added to, at the least.

[paul91]

I would also like to see this feature added.
On Mar 13, 2014 11:11 AM, "Scott Merrill" notifications@github.com wrote:

This module hard-codeshttps://github.com/puppetlabs/puppetlabs-apache/blob/master/templates/httpd.conf.erb#L54the LogFormat names in httpd.conf. That stinks for sites that rely on the
X-Forwarded-For header on servers behind a load balancer.

We can use the CustomLoghttps://github.com/puppetlabs/puppetlabs-apache/blob/master/templates/vhost.conf.erb#L43option on a per-vhost setting; but this means that we'd need to declare
that option for every single vhost. That stinks, as it introduces a lot of
repetition.

It'd be nice if the list of LogFormat definitions in httpd.conf could be
added to, at the least.

Reply to this email directly or view it on GitHubhttps://github.com//issues/678
.

[igalic]

+1

[skpy]

We worked around this by copying the httpd.conf.erb template into our role module, and using that version when implementing the apache class:

  class { '::apache':
    default_mods  => false,
    default_vhost => false,
    purge_configs => true,
    conf_template => 'role/httpd.conf.erb',
  }

In our copy of the template, we added the log directives we need. This works, but it means we need to track the puppetlabs/apache module a little more closely for changes.

[igalic]

Yeah, I can't imagine this to be very nice.
I'll take a stab at implementing this feature!

[igalic]

I highly welcome feedback on #682, while sliding down the hill to the office

[skpy]

Looks like a good start. Thanks for tackling this!
I'd add the following to params.pp:

  $log_formats = {
    combined => '%h %l %u %t "%r" %>s %b "%{Referer}i" "%{User-Agent}i"'
    common   => '%h %l %u %t \"%r\" %>s %b'
    referer  => '%{Referer}i -> %U'
    agent    => '%{User-agent}i'
  }

This should make this change transparent to current users, as it provides the same log format definitions as exist now.

[paul91]

I would like to second using those as the defaults. Other than that this patch is just what I need.

[igalic]

@skpy right now, I'm only appending new LogFormats to the list, I'm not replacing anything.

[chelnak]

Hello! We are doing some house keeping and noticed that this issue has been open for a long time.

We're going to close it but please do raise another issue if the issue still persists. 😄