Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discuss] Release 0.11.0 before merging Concat and 2.4 changes #594

Closed
igalic opened this issue Jan 28, 2014 · 6 comments
Closed

[discuss] Release 0.11.0 before merging Concat and 2.4 changes #594

igalic opened this issue Jan 28, 2014 · 6 comments

Comments

@igalic
Copy link
Contributor

igalic commented Jan 28, 2014

Hello happy people o/~

I'd like tag a new release for puppetlabs/apache before we proceed to merge the big new changes in.
@hunner and me believe that before doing so, we'll have to revert #545

Please give us some input!

@hunner
Copy link
Contributor

hunner commented Jan 29, 2014

Yeah, I think that #545 should definitely be reverted.

Did you want to try and get #552 in before? It's a pretty hefty change; adding apache::mpm and $apache_version parameters seem to be the biggest parts.

@blkperl
Copy link
Contributor

blkperl commented Jan 29, 2014

I want the acceptance tests fixed before the release (#592), I'm not convinced that the double quote PR didn't break things. I think we should let #552 sit in master for a while before releasing it. If we can get some Apache 2.4 spec tests running on the Fedora 18 nodeset then we should be in good shape. A centos7 or Fedora 20 nodeset would be awesome too.

@domcleal
Copy link
Contributor

For foreman-installer, we rely on Apache 2.4 support, so can point our submodule over to it as soon as it's merged to give continuous testing on Fedora 19 (and EL7 in a couple of months). That said, if it can be released in due course too, that'd be a big help as we're trying to use official releases.

@igalic
Copy link
Contributor Author

igalic commented Jan 29, 2014

So, the general idea is: revert #545, fix #592, release 0.11.0, then merge #552 and brace for the onslaught of issues to come with it.
I think the only question is, which version the one after 0.11.0 will be.

@igalic
Copy link
Contributor Author

igalic commented Jan 31, 2014

With the merge of #597, it's time to re-evaluate where we're standing here.

@blkperl
Copy link
Contributor

blkperl commented Feb 6, 2014

0.11.0 was released, time to merge the 2.4 changes and start testing.

@blkperl blkperl closed this as completed Feb 6, 2014
traylenator pushed a commit to traylenator/puppetlabs-apache that referenced this issue Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants