-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
adopt a more stable proxy configuration
adopt proxy configuration as documented by @niq (Nick Kew) http://www.apachetutor.org/admin/reverseproxies documents the This pattern is more resilient to shaky redirects from the backend This commit fixes #300.
- Loading branch information
Showing
2 changed files
with
20 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d77ebe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes configurations like /jenkins -> http://localhost:8080/jenkins fail
The proxypass reverse line should be "ProxyPassReverse /<%= proxy['path']%>" or even better it should match the last part of the backend url
8d77ebe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going to revert this change as discussed in #602 / #613