Same name type and provider #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a provider and a type with the same name conflict strings will overwrite the documentation of one of them with the other. That is if both a provider and a type are named apt_key, strings will write the type to doc/apt_key.html and the provider to doc/apt_key.html. The fix is to write the provider to doc/apt_key_provider.html and the type to doc/apt_key_type.html.
iankronquist
force-pushed
the
same-name-type-and-provider
branch
from
01bdc53 to
7814eea
Compare
|
There's a simple maintenance commit piggybacking here. I can cherry pick it away if you want. |
|
I can confirm this works for me as well
|
|
@ferventcoder Thanks for checking my work! I appreciate your help and review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.