Types and providers fixes #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iankronquist
force-pushed
the
types-and-providers-fixes
branch
from
5f8eec8 to
0b3edca
Compare
|
So these need to reference a real ticket. Is there an existing ticket that makes sense to reference? |
|
There also seem to be two commits titled "Handle directives with no types" should those be merged? |
In a Puppet type if the user documents a parameter with the directive, then Yard will read the parameter and think there is an empty docstring there. This will overwrite the docstring we extracted. The fix is simple -- overwrite our docstring with theirs, if our docstring exists at all.
This confusion persists from a very old attempt at implementing support for types and providers.
Parameter directives with no types will have `tag.type` set to nil. We cannot append nil to an array, so instead, place it in the array and flatten the array. If the property is empty the second entry in the array will be nil, as we expect. If the `tag.type` is an array of types we will have and array with the form: [tag.text, type1, type2, type3, ...]
iankronquist
force-pushed
the
types-and-providers-fixes
branch
from
0b3edca to
7f4b81e
Compare
|
Looks like I screwed up the rebase. Here it is again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes Shaigy found while doing QA. Thanks Shaigy!