Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forgot defined types #42

Merged
merged 2 commits into from
Jul 28, 2015
Merged

Forgot defined types #42

merged 2 commits into from
Jul 28, 2015

Conversation

iankronquist
Copy link
Contributor

@iankronquist iankronquist force-pushed the forgot-defined-types branch from 4c720a2 to 8699068 Compare July 28, 2015 00:10
@HAIL9000
Copy link
Contributor

@iankronquist Could you just quickly add a longer description for the first commit? It makes sense now with the context, but in the future it might be a little confusing

@iankronquist iankronquist force-pushed the forgot-defined-types branch from 8699068 to ad26bf8 Compare July 28, 2015 20:12
@iankronquist
Copy link
Contributor Author

@HAIL9000 done.

@HAIL9000
Copy link
Contributor

Hmmm that PDOC-33 commit just showed up. Does this need a rebase?

@iankronquist
(PDOC-19) Parse type information for defined types
2d2c03b 
I forgot to include the code which extracts the type information for the code
object in the defined types handler. Without this we do not extract type
information from defined types so warnings cannot be emitted and types in the
documentation are listed as Unknown.
@iankronquist
(maint) Fix typo in emitted html
9083023
@iankronquist iankronquist force-pushed the forgot-defined-types branch from ad26bf8 to 9083023 Compare July 28, 2015 20:28
@iankronquist
Copy link
Contributor Author

@HAIL9000 there we go.

HAIL9000 added a commit that referenced this pull request Jul 28, 2015
@HAIL9000
Merge pull request #42 from iankronquist/forgot-defined-types
e9167b1 
Forgot defined types
@HAIL9000 HAIL9000 merged commit e9167b1 into puppetlabs:master Jul 28, 2015
@chelnak chelnak added the bugfix label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iankronquist @HAIL9000 @chelnak