Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Fix rubocop lint warnings #374

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

gavindidrichsen
Copy link
Contributor

Summary

Fix failing nightly CI rubocop warnings:

➜  puppet-strings git:(maint_fix_rubocop_warnings) bundle exec rubocop --format github

::error file=lib/puppet-strings/describe.rb,line=69,col=44::Layout/ExtraSpacing: Unnecessary spacing detected.
::error file=lib/puppet-strings/yard/code_objects/function.rb,line=11,col=11::Lint/SymbolConversion: Unnecessary symbol conversion; use `:"puppet_functions_#{type}"` instead.
::error file=lib/puppet-strings/yard/code_objects/provider.rb,line=11,col=11::Lint/SymbolConversion: Unnecessary symbol conversion; use `:"puppet_providers_#{type}"` instead.
::error file=lib/puppet-strings/yard/code_objects/type.rb,line=172,col=36::Lint/SymbolConversion: Unnecessary symbol conversion; use `:"puppet_providers_#{name}"` instead.
::error file=lib/puppet-strings/yard/util.rb,line=38,col=23::Style/RedundantParentheses: Don't use parentheses around a logical expression.
➜  puppet-strings git:(maint_fix_rubocop_warnings) 

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
@gavindidrichsen gavindidrichsen marked this pull request as ready for review December 4, 2023 21:39
@gavindidrichsen gavindidrichsen requested a review from a team as a code owner December 4, 2023 21:39
@jordanbreen28 jordanbreen28 merged commit 73e92aa into main Dec 5, 2023
12 checks passed
@jordanbreen28 jordanbreen28 deleted the maint_fix_rubocop_warnings branch December 5, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants