(GH-332) Ensure PuppetStrings is loaded for tasks #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit users would receive an Undefined Constant error when attempting to generate a reference file via the provided Rake tasks. This was caused by the compact testing style for modules added in v3.0. In this case the parent, PuppetStrings is not properly loaded before Tasks. As a result the error above is caused. This commit adds a new module declaration to tasks.rb that will ensure that the PuppetStrings is properly loaded.
chelnak
force-pushed
the
GH-332-ensure_module_is_loaded
branch
from
0c860b4 to
0292153
Compare
LukasAud
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR users would receive an Undefined Constant error when attempting to generate a reference file via the provided Rake tasks.
This was caused by the compact testing style for modules added in v3.0.
In this case the parent, PuppetStrings is not properly loaded before Tasks. As a result the error above is caused.
This PR adds a new module declaration to tasks.rb that will ensure that the PuppetStrings is properly loaded.