Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DOCUMENT-1232) Add support for ensurable in types_extras_handler #281

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

joshcooper
Copy link
Contributor

Puppet's file type uses the ensurable method in an extra file, so add
support for that.

Puppet's `file` type uses the `ensurable` method in an extra file, so add
support for that.
@joshcooper joshcooper requested a review from a team as a code owner June 29, 2021 16:45
@joshcooper
Copy link
Contributor Author

Manually tested that puppet strings generates ensure docs for the file type:

$ grep ensure doc/puppet_types/file.html 
type should be specified in the <code>ensure</code> attribute.</p>
      <span class="name">ensure</span>
<li><code>absent</code> ensures the file doesn't exist, and deletes it if necessary.</li>
<li><code>file</code> ensures it's a normal file, and enables use of the <code>content</code> or
<li><code>directory</code> ensures it's a directory, and enables use of the <code>source</code>,
<li><code>link</code> ensures the file is a symlink, and <strong>requires</strong> that you also

@jpogran
Copy link
Contributor

jpogran commented Jun 30, 2021

Thanks for the work @joshcooper! Is there a specific issue/JIRA ticket that inspired this (so I can add it to the changelog)? If not I'll merge as is and put up a PR to amend the CHANGELOG with an Unreleased section for future releases.

@jpogran jpogran merged commit 242aefd into puppetlabs:main Jul 1, 2021
@joshcooper joshcooper deleted the file_ensurable branch July 1, 2021 18:40
@joshcooper
Copy link
Contributor Author

Ah sorry forgot to update this. The issue came about in https://tickets.puppetlabs.com/browse/DOCUMENT-1232

@da-ar da-ar changed the title Add support for ensurable in types_extras_handler (DOCUMENT-1232) Add support for ensurable in types_extras_handler Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants