(PDOC-27) Don't require options for 3x functions #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the 3x function handler assumed that at least two arguments (the name and one or more additional arguments) were passed into newfunction when creating a 3x function. However that is not actually required, the only argument needed is the name. Update the 3x function handler so that it will not throw and exception if only one argument is given.
Prior to this commit, the Gemfile for strings did not specify which version of rspec to use. When it started using rspec 3, the tests that relied upon the rspec-html-matchers gem began to fail, likely because that gem is not yet compatible with the new version of rspec. Update the Gemfile so that we explicitly use an older version of rspec to prevent tests from failing. We will have to either wait for rspec-html-matchers to catch up or find a new way of testing the HTML output before we can update to rspec 3.
|
I fixed the rspec version issue, but now it looks like I now have legitimate failures for Ruby 2x. ಠ_ಠ Looking into these now |
Prior to this commit, the fix for the 3x function issue was trying to create an empty hash by calling Hash[ [[]] ] which in Ruby 1.9.3 produced and empty hash. However this is not the case in Ruby 2.0 and up. Therefor, fix up the code so that it does not rely on Hash[ [[]] ] creating and empty hash.
hlindberg
added a commit
that referenced
this pull request
Feb 18, 2015
…_should_accept_one_or_more_arguments (PDOC-27) Don't require options for 3x functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the 3x function handler assumed that at
least two arguments (the name and one or more additional arguments)
were passed into newfunction when creating a 3x function. However
that is not actually required, the only argument needed is the name.
Update the 3x function handler so that it will not throw and exception
if only one argument is given.