(PDOC-135) Detect return_type calls in 4.x function dispatches
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlindberg
approved these changes
Nov 14, 2016
| log.warn "A duplicate block parameter was found for Puppet function '#{object.name}' at #{child.file}:#{child.line}." | ||
| if method_name == 'return_type' | ||
| overload_tag.tag(:return).types = [node_as_string(child.parameters[0])] | ||
| else |
There was a problem hiding this comment.
could just do a next to get out of this conditional. Then there is no need to nest the rest of the logic under this conditional's else (right now there is a construct else if``which should really be anelseif- but since all other cases usenext` this case ('return_type') could use that as well as it is easier to read without the nesting.
There was a problem hiding this comment.
@hlindberg updated.
Previously, Strings ignored calls to `return_type` in Puppet 4.x API function dispatches, preventing the return types of overloads from being automatically determined. This commit adds a check for a node with a `return_type` call and handles it properly.
whopper
force-pushed
the
PDOC-135/4x_dispatch_return_type
branch
from
e988b81 to
36bc0dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Strings ignored calls to
return_typein Puppet 4.x APIfunction dispatches, preventing the return types of overloads from
being automatically determined. This commit adds a check for a node
with a
return_typecall and handles it properly.