Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bug) - Corrects suggestion for has_key method #12

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

jordanbreen28
Copy link
Collaborator

@jordanbreen28 jordanbreen28 commented Oct 3, 2024

This commit corrects an issue where the suggested replacement for the has_key funciton was to use puppet lang matchers. This is not a suitable replacement, and instead should use puppets 'if "key" in $my_hash' expression instead.

Additional context:
puppetlabs/puppetlabs-stdlib#1319

@jordanbreen28 jordanbreen28 added the bug Something isn't working label Oct 3, 2024
@jordanbreen28 jordanbreen28 force-pushed the bug-update_suggestion_for_has_key branch from f2ebed6 to df00738 Compare October 3, 2024 13:51
This commit corrects an issue where the suggested replacement for the
has_key funciton was to use puppet lang matchers. This is not a suitable
replacement, and instead should use puppets 'if "key" in $my_hash'
expression instead.
@jordanbreen28 jordanbreen28 force-pushed the bug-update_suggestion_for_has_key branch from df00738 to 09daa25 Compare October 3, 2024 13:51
@jordanbreen28 jordanbreen28 marked this pull request as ready for review October 3, 2024 13:52
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner October 3, 2024 13:52
@david22swan david22swan merged commit ca34298 into main Oct 3, 2024
4 checks passed
@david22swan david22swan deleted the bug-update_suggestion_for_has_key branch October 3, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants