(maint) Pin bundler to 2.4.22, which supports Ruby 2.7.4 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently pin our Ruby version in this Dockerfile to 2.7.4, so we also need to pin bundler to a version compatible with that. Updating the Ruby version is a bigger project that would need to be looked into separately.
nwolfe
approved these changes
Feb 5, 2024
This deps file contains an RSA key that was used to for GPG signing of one of the deps. Trivy is incorrectly flagging it as a leaked AWS key. All future versions of nokogiri contain this key in their deps file, so we are just skipping the file when doing the Trivy scan, since it is not a real security issue.
One of the files in the aws-sdk-core gem contains some comments with tokens in them. This is causing our Trivy scan to fail. This commit skips scanning that file, since these tokens aren't a real security issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently pin our Ruby version in this Dockerfile to 2.7.4, so we also need to pin bundler to a version compatible with that. Updating the Ruby version is a bigger project that would need to be looked into separately.