Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) pin PDK version to 2.7.1 #137

Merged
merged 1 commit into from
Jul 10, 2023
Merged

(maint) pin PDK version to 2.7.1 #137

merged 1 commit into from
Jul 10, 2023

Conversation

eputnam
Copy link
Contributor

@eputnam eputnam commented Jul 10, 2023

We don't want to release PDK 3.0.0 yet in puppet-dev-tools, so to prevent automatic upgrades with our build process, this change pins the PDK version to the current 2.x version.

@eputnam eputnam requested a review from a team as a code owner July 10, 2023 18:37
Copy link
Contributor

@Magisus Magisus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a ticket for the base image update, if you want to make a separate commit tagged with that ticket number? https://tickets.puppetlabs.com/browse/CDPE-5739

@eputnam
Copy link
Contributor Author

eputnam commented Jul 10, 2023

oops. i didn't realize that was in here. i'm going to get rid of the OS bump.

Copy link

@abottchen abottchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

We don't want to release PDK 3.0.0 yet in puppet-dev-tools, so to
prevent automatic upgrades with our build process, this change pins the
PDK version to the current 2.x version.
@eputnam eputnam merged commit 6cca50a into main Jul 10, 2023
1 check passed
@eputnam eputnam deleted the maint/pin-pdk-271 branch July 10, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants