Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(IAC-1603) Removing usage of resource_api module and puppet5 support #429

Merged
merged 2 commits into from
May 14, 2021

Conversation

pmcmaw
Copy link
Contributor

@pmcmaw pmcmaw commented May 13, 2021

As of puppet6, the resource_api gem is automatically included in Puppet therefore the module has been deprecated. Removing all references to the resource_api module in the codebase.

@pmcmaw pmcmaw added the bugfix label May 13, 2021
@puppet-community-rangefinder
Copy link

cisco_ios::install::server is a class

that may have no external impact to Forge modules.

cisco_ios::server is a class

that may have no external impact to Forge modules.

This module is declared in 4 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@elainemccloskey
Copy link

@pmcmaw Would the version_requirement in the metadata for puppet need updated to puppet 6 too?

@pmcmaw pmcmaw force-pushed the IAC-1603 branch 3 times, most recently from 717af4c to 2b153c8 Compare May 13, 2021 13:32
@pmcmaw pmcmaw changed the title (IAC-1603) Removing usage of resource_api module (IAC-1603) Removing usage of resource_api module and puppet5 support May 13, 2021
@DavidS DavidS merged commit 66b2d6e into puppetlabs:main May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants