(BKR-1445) Update Windows agent paths for puppet6 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseywilliams
commented
Sep 6, 2018
| }, | ||
| 'pwindows' => { #pure windows | ||
| 'pswindows' => { # pure windows |
There was a problem hiding this comment.
I kept seeing 'pswindows' instead of 'pwindows' elsewhere, so I've updated this to match -- please let me know if I'm wrong here
caseywilliams
force-pushed
the
PA-1923/windows-paths
branch
from
5a7affc to
0582962
Compare
|
PR tests have failed, but it seems unrelated? Actual output is here |
caseywilliams
changed the title
caseywilliams
force-pushed
the
PA-1923/windows-paths
branch
from
0582962 to
d557ad8
Compare
The install locations for puppet-agent in puppet6 have been updated; This adds the new install locations to the PATH.
caseywilliams
force-pushed
the
PA-1923/windows-paths
branch
from
d557ad8 to
3334f75
Compare
caseywilliams
changed the title
|
The Jenkins, retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PA-1923, we're updating install paths in Windows agents so that they more closely match the paths used in *nix agents -- this PR adds the new location of the vendored ruby executable to the default PATHs set up by beaker while installing puppet-agent. We could make this distinction based on the collection name, but it seemed less disruptive to just include all the possible paths at once.
The pathing work hasn't been merged in puppet-agent yet (the PR is here), so I'm putting the blocked label on this PR for the moment while I finish testing everything there.