Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

fix augeas pkg.url #845

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented May 8, 2024

latest versions are not available on download.augeas.net

@h0tw1r3 h0tw1r3 added the bug Something isn't working label May 8, 2024
@h0tw1r3 h0tw1r3 requested review from a team as code owners May 8, 2024 04:47
@@ -15,7 +15,7 @@
raise "augeas version #{version} has not been configured; Cannot continue."
end

pkg.url "http://download.augeas.net/augeas-#{pkg.get_version}.tar.gz"
pkg.url "https://github.com/hercules-team/augeas/releases/download/release-#{pkg.get_version}/augeas-#{pkg.get_version}.tar.gz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this broke in 9c6456a AFAIK, only 1.13.0+ is on github

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshcooper fixed!

@h0tw1r3 h0tw1r3 force-pushed the fix/augeas-source branch 2 times, most recently from 52e5f91 to eb42f9e Compare May 8, 2024 16:21
Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not blocking but maybe add a comment that the fallback to download.augeas.net can be removed once we stop supporting augeas 1.12.0

@h0tw1r3 h0tw1r3 force-pushed the fix/augeas-source branch from eb42f9e to b304f4f Compare May 8, 2024 21:17
versions after 1.12.0 are only available from Github
@h0tw1r3 h0tw1r3 force-pushed the fix/augeas-source branch from b304f4f to b2f5a5b Compare May 8, 2024 21:29
@h0tw1r3 h0tw1r3 merged commit cb55e96 into puppetlabs-toy-chest:master May 8, 2024
3 checks passed
@h0tw1r3 h0tw1r3 deleted the fix/augeas-source branch May 8, 2024 22:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants