Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

Remove unused mingw package #836

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

joshcooper
Copy link
Contributor

@joshcooper joshcooper commented Apr 22, 2024

Commit aea5e88 added mingw on windows-2012r2-x64 (only) for bootsnap (in bolt). Later the bootsnap changes were removed 65fd77a but the mingw package was not removed. As a result, we've continued to install the package:

mingw v8.1.0
mingw package files install completed. Performing other installation steps.
Downloading mingw 64 bit from 'https://sourceforge.net/projects/mingw-w64/files/Toolchains%20targetting%20Win64/Personal%20Builds/mingw-builds/8.1.0/threads-posix/seh/x86_64-8.1.0-release-posix-seh-rt_v6-rev0.7z/download'
Download of x86_64-8.1.0-release-posix-seh-rt_v6-rev0.7z (47.08 MB) completed.
Hashes match.
Extracting C:\Users\Administrator\chocolatey\mingw\8.1.0\x86_64-8.1.0-release-posix-seh-rt_v6-rev0.7z to C:\ProgramData\chocolatey\lib\mingw\tools\install...

We don't actully need mingw, as the structured exception handling libraries are implemented in the mingw-w64 we've already installed:

Running Install-ChocolateyZipPackage -packageName 'mingw-w64' -url 'C:\ProgramData\chocolatey\lib\mingw-w64\tools\x86_64-5.2.0-release-win32-seh-rt_v4-rev0.7z' -unzipLocation 'C:\tools'

Commit aea5e88 added mingw on
windows-2012r2-x64 (only) for bootsnap (in bolt). Later the bootsnap changes
were removed 65fd77a but the mingw package was
not removed. As a result, we've continued to install the package:

    mingw v8.1.0
    mingw package files install completed. Performing other installation steps.
    Downloading mingw 64 bit from 'https://sourceforge.net/projects/mingw-w64/files/Toolchains%20targetting%20Win64/Personal%20Builds/mingw-builds/8.1.0/threads-posix/seh/x86_64-8.1.0-release-posix-seh-rt_v6-rev0.7z/download'
    Download of x86_64-8.1.0-release-posix-seh-rt_v6-rev0.7z (47.08 MB) completed.
    Hashes match.
    Extracting C:\Users\Administrator\chocolatey\mingw\8.1.0\x86_64-8.1.0-release-posix-seh-rt_v6-rev0.7z to C:\ProgramData\chocolatey\lib\mingw\tools\install...

We don't actully need mingw, as the structured exception handling
libraries are implemented in the mingw-w64 we've already installed:

    Running Install-ChocolateyZipPackage -packageName 'mingw-w64' -url 'C:\ProgramData\chocolatey\lib\mingw-w64\tools\x86_64-5.2.0-release-win32-seh-rt_v4-rev0.7z' -unzipLocation 'C:\tools'
@joshcooper joshcooper marked this pull request as ready for review April 23, 2024 00:47
@joshcooper joshcooper requested review from a team as code owners April 23, 2024 00:47
@joshcooper joshcooper added the maintenance Maintenance chores are typically excluded from changelogs label Apr 23, 2024
@cthorn42 cthorn42 merged commit 070a48b into puppetlabs-toy-chest:master Apr 23, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Maintenance chores are typically excluded from changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants