(GH-63) Allow additional tool args to be set within validate.yml #64

da-ar · 2021-12-12T10:07:23Z

---
tools:
  - name: "group/modules"
  - name: "puppetlabs/rubocop"
    args: ["--auto-correct"]
  - name: "puppetlabs/epp"

Surfaces the exit codes and errors raised by the tool within the container, up to the main application. This affects the exit status of the `exec` command.

Uses shlex library to split out the string correctly

``` --- tools: - name: "group/modules" - name: "puppetlabs/rubocop" args: ["--auto-correct"] - name: "puppetlabs/epp" ```

da-ar added 3 commits December 10, 2021 08:24

(GH-61) Handle tool exit codes

cebe503

Surfaces the exit codes and errors raised by the tool within the container, up to the main application. This affects the exit status of the `exec` command.

(GH-52) Handle args with spaces

9aac438

Uses shlex library to split out the string correctly

(GH-63) Allow additional tool args to be set within validate.yml

58a5c0e

``` --- tools: - name: "group/modules" - name: "puppetlabs/rubocop" args: ["--auto-correct"] - name: "puppetlabs/epp" ```

da-ar requested a review from a team as a code owner December 12, 2021 10:07

sanfrancrisko added the enhancement New feature or request label Dec 13, 2021

sanfrancrisko approved these changes Dec 13, 2021

View reviewed changes

sanfrancrisko merged commit 2fbf36e into main Dec 13, 2021

sanfrancrisko deleted the GH-63/main/update-validateyml branch December 13, 2021 10:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(GH-63) Allow additional tool args to be set within validate.yml #64

(GH-63) Allow additional tool args to be set within validate.yml #64

da-ar commented Dec 12, 2021

(GH-63) Allow additional tool args to be set within validate.yml #64

(GH-63) Allow additional tool args to be set within validate.yml #64

Conversation

da-ar commented Dec 12, 2021