Docker backend for Gems #43

da-ar · 2021-12-06T12:07:47Z

This PR enables the PRM functionality that allows a GEM tool to be executed using the Docker backend.

When run will look in the current working directory for a validate.yml. It wil then execute against all these tools.
This needs removed from the prm exec exec and only used in prm validate. However it demonstrates the functionaliy.

dist\prm_windows_amd64\prm.exe exec

This command will look in the tools directory for a config that matches puppetlabs/rubocop.

dist\prm_windows_amd64\prm.exe exec puppetlabs/rubocop

If found it will:

parse the config into the data structure
check if docker has an image that matches a unique name made up of the author, id, version of the tool and the user configured puppet version
if no image is present it will generate dockerfile based on the tool config and create the image on the local system
when the image is created it will then create and run the conatiner against the codedir.
It will output to stdout the response from the tool

sanfrancrisko

Excellent work @da-ar ! 🥇

pkg/prm/docker.go

michaeltlombardi

Overall this rules, unbelievably happy to see this come so far so fast; a few questions and suggestions but otherwise 🎉

cmd/exec/exec.go

pkg/prm/docker.go

pkg/prm/prm.go

This commit provides the basic flow when the image already exists.

This commit allows an image to be created when it doesn't exist on the system

michaeltlombardi

🥁 🦖 💥

``` gem: compatibility: - 2.5: - "puppetlabs_spec_helper": "2.15.0" - 2.4: - "puppetlabs_spec_helper": "2.15.0" ```

This flag allows arguments to be passed to the tool. We are unable to rely on cobra to pass unknown args and flags.

Declare within the interface the used Client function

da-ar force-pushed the gh-35/main/docker-backend branch 12 times, most recently from be09f1b to 1ca4888 Compare December 9, 2021 10:38

da-ar marked this pull request as ready for review December 9, 2021 11:19

da-ar requested a review from a team as a code owner December 9, 2021 11:19

sanfrancrisko approved these changes Dec 9, 2021

View reviewed changes

pkg/prm/docker.go Outdated Show resolved Hide resolved

da-ar force-pushed the gh-35/main/docker-backend branch from 1ca4888 to e10c8a0 Compare December 9, 2021 12:53

michaeltlombardi suggested changes Dec 9, 2021

View reviewed changes

da-ar force-pushed the gh-35/main/docker-backend branch from 2792930 to 20b0cd4 Compare December 9, 2021 13:26

da-ar added 7 commits December 9, 2021 13:53

(GH-35) Add validate.yml check to prm exec

cd38f5e

(GH-35) Refactor to preExecute to store to PRM tool cache

e2fc52b

(GH-25) Add docker commands for Gem

0327df7

(GH-35) Image exists

ace4daa

This commit provides the basic flow when the image already exists.

(GH-35) Create image

e4c900a

This commit allows an image to be created when it doesn't exist on the system

(maint) linting fixes

a3f58b8

(maint) Support for running config change

861eb85

da-ar force-pushed the gh-35/main/docker-backend branch from 20b0cd4 to 2b8d763 Compare December 9, 2021 13:53

michaeltlombardi approved these changes Dec 9, 2021

View reviewed changes

da-ar added 3 commits December 9, 2021 15:19

(GH-35) Handle gem compatibility

54fa956

``` gem: compatibility: - 2.5: - "puppetlabs_spec_helper": "2.15.0" - 2.4: - "puppetlabs_spec_helper": "2.15.0" ```

(GH-35) Add toolArgs flag

5875802

This flag allows arguments to be passed to the tool. We are unable to rely on cobra to pass unknown args and flags.

(GH-35) Add non-blocking log output

77542ee

da-ar added 2 commits December 9, 2021 15:19

(GH-35) Use DockerClientI interface

ce15f1f

Declare within the interface the used Client function

(GH-35) Add timeout duration to context used by Docker client

7fa4180

da-ar force-pushed the gh-35/main/docker-backend branch from 2b8d763 to 7fa4180 Compare December 9, 2021 15:20

michaeltlombardi merged commit 96a605f into main Dec 9, 2021

michaeltlombardi deleted the gh-35/main/docker-backend branch December 9, 2021 15:48

petergmurphy added the maintenance label May 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Docker backend for Gems #43

Docker backend for Gems #43

da-ar commented Dec 6, 2021 •

edited

Loading

sanfrancrisko left a comment

michaeltlombardi left a comment

michaeltlombardi left a comment

Docker backend for Gems #43

Docker backend for Gems #43

Conversation

da-ar commented Dec 6, 2021 • edited Loading

sanfrancrisko left a comment

Choose a reason for hiding this comment

michaeltlombardi left a comment

Choose a reason for hiding this comment

michaeltlombardi left a comment

Choose a reason for hiding this comment

da-ar commented Dec 6, 2021 •

edited

Loading