This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
(GH-13) Implement PRM install #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petergmurphy
force-pushed
the
gh-13/main/implement_prm_install
branch
15 times, most recently
from
6ccac5c to
4aac8d8
Compare
petergmurphy
force-pushed
the
gh-13/main/implement_prm_install
branch
from
4aac8d8 to
9056023
Compare
The install command has been created and all appropriate help information, arguments and parameters have been added to give it the same install functionality as that found on pct. Added the `config_processor.go` with functions to appropriately process the prm config files after they're extracted from the `tar.gz` tool files. The `ProcessConfig` method is called from the genericised `install` package which is located in the pdkgo repository. Added appropriate acceptance and unit testing along with test data and mocking modules to supplement the testing.
petergmurphy
force-pushed
the
gh-13/main/implement_prm_install
branch
from
9056023 to
921d602
Compare
sanfrancrisko
approved these changes
Dec 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of PR:
The install command has been created and all appropriate
help information, arguments and parameters have been added to give it the same install
functionality as that found on pct.
Added the
config_processor.gowith functions to appropriately processthe prm config files after they're extracted from the
tar.gztool files.The
ProcessConfigmethod is called from the genericisedinstallpackage which islocated in the pdkgo repository.
Added appropriate acceptance and unit testing along with test data and
mocking modules to supplement the testing.
Resolves: #42