This repository was archived by the owner on Apr 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea0b24c
to
0a86e6c
Compare
da-ar
reviewed
Oct 15, 2021
cdcbe08
to
3c18689
Compare
3c18689
to
efe066f
Compare
f22d1a2
to
c9f9b10
Compare
2724a90
to
69876ff
Compare
42b3882
to
b4db3f3
Compare
aa09395
to
cc751a1
Compare
42e5fa7
to
d0ac23f
Compare
f74d11c
to
b730881
Compare
Prior to this commit, it was observed on Github Actions CI runs that the `macos-latest` (and to a lesser extent, the `ubuntu-latest`) runners would occasionally fail to install the PCT package. This commit added the following functionality to `install.sh`: - Fetches the releases checksums file to perform verification on the download - Wraps all curl commands in a retry loop, to improve reliability and mitigate failures caused by network blips - Inspect the HTTP Response Code from each curl command - Output debug logging to help diagnose / investigate failures Debug logging is enabled by setting the ENV VAR `PCT_INSTALL_DEBUG`
b730881
to
c308ef8
Compare
This commit adds a new Github Actions workflow that executes the `install.(ps1|sh)` script on a Linux, macOS and Ubuntu runner and verifies that the installation succeeds.
Prior to this commit, there was a call to api.github.com to obtain the releases listing, which was then subsequently processed to determine the latest ver. Calls to the API were triggering throttling mechanisms and causing CI test runs to fail. This commit modifies the `.goreleaser.yml` config to remove the version from the build artefacts published, which then allows us to hit `releases/latest/` on Github (bypassing the API). The `install.(ps1|sh)` scripts have also been updated to use this new URI.
55d3218
to
82d39bc
Compare
da-ar
approved these changes
Oct 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
0.5.0
.gorelease.yml
to remove the version from the build artefacts, facilitating the ability to retrieve the latest buildsinstall.(ps1|sh)
scripts to remove calls to theapi.github.com
Closes: #258