Skip to content
This repository was archived by the owner on Apr 17, 2023. It is now read-only.

(GH-83) Allow for workspace configuration overrides #115

Merged

Conversation

da-ar
Copy link

@da-ar da-ar commented Jun 8, 2021

This commit introduces workspace configs.

If a pct.yml exists in the template creation directory, it will use those over user config, which is used over template defaults.

@da-ar da-ar force-pushed the GH-83/main/workspace-config branch 2 times, most recently from b7ed6fc to 19f2210 Compare June 8, 2021 13:44
@da-ar da-ar marked this pull request as ready for review June 8, 2021 13:54
@da-ar da-ar requested a review from a team as a code owner June 8, 2021 13:54
@da-ar
Copy link
Author

da-ar commented Jun 8, 2021

Can be used with puppetlabs-toy-chest/pct-templates#16

@jpogran jpogran added the enhancement New feature or request label Jun 8, 2021
@jpogran jpogran linked an issue Jun 8, 2021 that may be closed by this pull request
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! We need to update the Overriding Template Defaults section of the README as well so we document the additional override.

Also, we should add this to the CHANGELOG in the unreleased section as an added feature for release time

@da-ar
Copy link
Author

da-ar commented Jun 9, 2021

Looking great! We need to update the Overriding Template Defaults section of the README as well so we document the additional override.

PR now up, we had docs a seperate ticket #122

@jpogran
Copy link
Contributor

jpogran commented Jun 9, 2021

You are correct, I got myself confused. Still need a changing entry here though

This commit introduces workspace configs.

If a `pct.yml` exists in the template creation directory, it will use those over user config, which is used over template defaults.
@da-ar da-ar force-pushed the GH-83/main/workspace-config branch from 19f2210 to 31fc89a Compare June 9, 2021 11:31
@da-ar da-ar requested a review from jpogran June 9, 2021 12:50
@jpogran jpogran merged commit fc78f71 into puppetlabs-toy-chest:main Jun 9, 2021
@da-ar da-ar deleted the GH-83/main/workspace-config branch August 26, 2021 09:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspace based configuration
2 participants