Choreography plugins: Only call update_ui() in Capture #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes HMD3DChoreographyPlugin crash in Service, as Service does not initialize any plugin UI.
romanroibu
approved these changes
Jun 24, 2020
pfaion
suggested changes
Jun 24, 2020
There was a problem hiding this comment.
I'm getting logspams with
service - [DEBUG] calibration_choreography.hmd_plugin: Disregarding notification: notify.service_process.ui.should_update
Maybe we should remove this debug message from all choreo plugins? It's in base_plugin and hmd_plugin.
It doesn't really tell us anything.
def on_notify(self, note_dict):
# ...
try:
note = ChoreographyNotification.from_dict(note_dict)
except ValueError:
note_name = note_dict.get("topic", None) or note_dict.get("subject", None)
logger.debug(f"Disregarding notification: {note_name}")
return
# ...Given that every plugin receives every notification, this debug message results in a lot of unwanted log messages. Therefore, the plugin will simply ignore unknown/unexpected notifications.
Given that every plugin receives every notification, this debug message results in a lot of unwanted log messages. Therefore, the plugin will simply ignore unknown/unexpected notifications.
pfaion
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes HMD3DChoreographyPlugin crash in Service, as Service does not initialize any plugin UI. See dedicated change commit: e2d5170