Merge Pupil Remote and Frame Publisher plugins #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papr
reviewed
May 20, 2020
|
|
||
| # UI | ||
| self.__frame_publisher_ui_menu = FramePublisherMenu(self.__frame_publisher) | ||
| self.__pupil_remote_ui_menu = PupilRemoteMenu() |
There was a problem hiding this comment.
UI should not be initialized in __init__() if possible.
There was a problem hiding this comment.
the components themselves don't call any UI function and don't create any pyglui instances in their __init__.
do you still think that initializing these objects should move to init_ui?
romanroibu
force-pushed
the
merge-pupil-remote-and-frame-publisher-plugins
branch
from
93f68b5
to
885aacb
Compare
papr
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Frame PublisherandPupil Remoteplugins into a singleNetwork APIplugin