Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on start #35

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Fix crash on start #35

merged 4 commits into from
Dec 17, 2024

Conversation

gavrilikhin-d
Copy link
Contributor

PR that implements fix from #34.

Also marks start and stop as async, to be able to catch promise rejections from js code.

Note: did not check iOS code

@gavrilikhin-d
Copy link
Contributor Author

gavrilikhin-d commented Aug 8, 2023 •
edited
Loading

Should prevent crashes in #22 and #15. However, callback, obviously, will never be called

@gavrilikhin-d
Copy link
Contributor Author

Also fixes build issue #33

@gavrilikhin-d
Copy link
Contributor Author

@punarinta can you check this PR?

@punarinta punarinta merged commit 7197831 into punarinta:master Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavrilikhin-d @punarinta