Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset peerip only if remote_addr_header is set #2609

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

calvinxiao
Copy link
Contributor

Description

In tcp mode when both remote_addr_value and remote_addr_header are not set, client.peerip method
calls @io.peeraddr in every request, I dont't think we need to reset @peerip to nil in such condition.

@io.peeraddr uses two syscalls getpeername and recevfrom, by caching the @peerip in Client instance,
we can save two syscalls on every request in an established connection, except for the first request.

hello.ru performance improvement:

  • master, 4107 RPS
  • caching peerip, 5224 RPS

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@nateberkopec nateberkopec added this to the 5.3.0 milestone Apr 24, 2021
@nateberkopec nateberkopec merged commit 01ffec5 into puma:master Apr 26, 2021
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants