Reset peerip only if remote_addr_header is set #2609
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
tcp
mode when bothremote_addr_value
andremote_addr_header
are not set,client.peerip
methodcalls
@io.peeraddr
in every request, I dont't think we need to reset@peerip
tonil
in such condition.@io.peeraddr
uses two syscallsgetpeername
andrecevfrom
, by caching the@peerip
inClient
instance,we can save two syscalls on every request in an established connection, except for the first request.
hello.ru
performance improvement:Your checklist for this pull request
[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.