[DOWNSTREAM TEST] Update GitHub Actions workflows. #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulumi-bot
added
the
impact/no-changelog-required
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
danielrbradley
added a commit
to pulumi/ci-mgmt
that referenced
this pull request
May 30, 2024
Write an explicit status check called "Sentinel" which will only pass if this code really runs. Once rolled out, we can make this the only required check for PRs, then remove the old conditionals on this job and remove the previous step. This is a follow-up to the conversation #942 (comment) where we debated the merits of a single required check if we could simplify the current sentinel logic to make it more reliable. Here's the test run in the xyz provider: https://github.com/pulumi/pulumi-xyz/actions/runs/9292939832?pr=145 Here's the old and new sentinel checks shown on the [test PR](pulumi/pulumi-xyz#145): 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated by the pull-request workflow in the pulumi/ci-mgmt repo, from commit 80d545d7eb779c4255830455385f562059648536.