Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add richer name transformation support #297

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Add richer name transformation support #297

merged 2 commits into from
Nov 18, 2020

Conversation

lukehoban
Copy link
Contributor

@lukehoban lukehoban requested a review from stack72 November 15, 2020 00:01
@github-actions
Copy link

Diff for pulumi-azuread with merge commit dfd84e7

@github-actions
Copy link

Diff for pulumi-random with merge commit dfd84e7

@lukehoban lukehoban added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 15, 2020
@github-actions
Copy link

Diff for pulumi-azure with merge commit dfd84e7

@github-actions
Copy link

Diff for pulumi-aws with merge commit dfd84e7

stack72
stack72 approved these changes Nov 15, 2020
View reviewed changes
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is great - the ability to pass a custom function for the resource is going to be very interesting for these types of scenarios

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 630dc75

@github-actions
Copy link

Diff for pulumi-random with merge commit 630dc75

@github-actions
Copy link

Diff for pulumi-gcp with merge commit dfd84e7

@github-actions
Copy link

Diff for pulumi-azure with merge commit 630dc75

@github-actions
Copy link

Diff for pulumi-aws with merge commit 630dc75

@lukehoban lukehoban mentioned this pull request Nov 15, 2020
Closed
@github-actions
Copy link

Diff for pulumi-gcp with merge commit 630dc75

@stack72 stack72 merged commit f510bbc into master Nov 18, 2020
@stack72 stack72 deleted the lukehoban/967 branch November 18, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stack72 stack72 stack72 approved these changes

Assignees
No one assigned
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukehoban @stack72