Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run provider-supplied edit rules before example code conversion #2435

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

guineveresaenger
Copy link
Contributor

@guineveresaenger guineveresaenger commented Sep 20, 2024

This code is required to successfully apply the edit rules needed for pulumi/pulumi-libvirt#426.

It covers the case for when the upstream file's code sections need to be adjusted for code conversion to work.

It adds a complete index file test which tests the entire plainDocsParser function.
In support of https://github.com/pulumi/home/issues/3598.

  • Run provider-supplied edit rules before example conversion. Add complete file tests, with and without provider-supplied edits
  • clean up tests

Add complete file tests, with and without provider-supplied edits
@guineveresaenger guineveresaenger requested a review from a team September 20, 2024 18:42
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.

Project coverage is 57.44%. Comparing base (1cb7594) to head (c55ae3c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/tfgen/installation_docs.go 42.85% 10 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2435      +/-   ##
==========================================
+ Coverage   57.43%   57.44%   +0.01%     
==========================================
  Files         369      369              
  Lines       50209    50265      +56     
==========================================
+ Hits        28836    28874      +38     
- Misses      19795    19806      +11     
- Partials     1578     1585       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant