auto: Fix inline programs timing out in CI #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't tie up shared threadpool threads blocked on reading stdout/stderr when running commands, which can lead to deadlocks running inline programs when no thread pool threads are available to make forward progress. Similarly, when reading the event log, we can use a single thread as to not block a shared threadpool thread. We also don't need to write stdin using a thread.
Instead of blocking, we can complete the request by calling `onNext` and `onCompleted` asynchronously from a continuation after running the inline program.
Also reduce the timeout to 1 minute in both lifecycle tests.
justinvp
added
the
impact/no-changelog-required
tgummerer
approved these changes
Feb 7, 2025
| semaphore.release(); | ||
| } | ||
| }); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Is there a reason why this is not just a finally, removing the need for the nested try/finally?
There was a problem hiding this comment.
If it was a finally here, I think it'll be called too soon, because runAsync(program).handle(...) is async, and will return immediately. I want to release the lock after the inline program is finished running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1641
Three commits:
1. Don't block thread pool threads
Don't tie up shared thread pool threads blocked on reading stdout/stderr when running commands, which can lead to deadlocks running inline programs when no thread pool threads are available to make forward progress.
Similarly, when reading the event log, we can use a single thread as to not block a shared thread pool thread.
We also don't need to write stdin using a thread.
2. Don't block in the gRPC language server's
runmethodInstead of blocking, we can complete the request by calling
onNextandonCompletedasynchronously from a continuation after running the inline program.3. Unskip
testStackLifecycleInlineProgramtestAlso reduce the timeout to 1 minute in both lifecycle tests.