Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump converter version #2037

Merged
merged 4 commits into from
May 30, 2024
Merged

Bump converter version #2037

merged 4 commits into from
May 30, 2024

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov mentioned this pull request May 29, 2024
Closed
@github-actions GitHub Actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

iwahbe
iwahbe reviewed May 29, 2024
View reviewed changes
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run make ci-mgmt tfgen build_sdks.

@VenelinMartinov
Copy link
Contributor Author

I can't get the right sdk to generate here. I tried plugin rm --all but still I get the old SDK.

Any ideas?

@iwahbe
Copy link
Member

iwahbe commented May 30, 2024 •
edited
Loading

I can't get the right sdk to generate here. I tried plugin rm --all but still I get the old SDK.

Any ideas?

Try deleting the bin folder. It might be a caching issue. I tried that, it didn't work.

I'm now trying PULUMI_HOME=.pulumi pu plugin rm -ya and then regenerating. That worked.

@VenelinMartinov VenelinMartinov enabled auto-merge (squash) May 30, 2024 17:30
@VenelinMartinov VenelinMartinov merged commit 9fa25f4 into master May 30, 2024
17 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/bump_converter_version branch May 30, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwahbe iwahbe iwahbe left review comments

@guineveresaenger guineveresaenger Awaiting requested review from guineveresaenger

Assignees

@VenelinMartinov VenelinMartinov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in Cloud SQL
2 participants
@VenelinMartinov @iwahbe