Fix mismatch in name for package #601
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
iwahbe
approved these changes
Nov 1, 2024
guineveresaenger
added a commit
to pulumi/pulumi-terraform-bridge
that referenced
this pull request
Nov 1, 2024
This pull request swaps out use of `g.info.Name` for `g.pkg.Name().String()` when determining the name of the provider for title and download link purposes. `g.info.Name` refers to the upstream Terraform provider name. We need to use the Pulumi package name instead. Fortunately the bridge already knows how to do this, so this pull request swaps out the package name getter and adjusts the parser test provider to have a pkg name. Fixes pulumi/pulumi-f5bigip#598. PR in that provider with these changes: pulumi/pulumi-f5bigip#601
guineveresaenger
added
awaiting/bridge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo PR for pulumi/pulumi-terraform-bridge#2562. Once that is merged and this provider uses that bridge version,
we can close #598.