-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(identity): add support to setup OIDC provider #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lblackstone
reviewed
Feb 4, 2020
metral
force-pushed
the
metral/oidc
branch
9 times, most recently
from
February 5, 2020 21:45
3ee444b
to
b08f36e
Compare
Feedback has been addressed. PTAL @lblackstone |
lblackstone
approved these changes
Feb 5, 2020
Any feedback @lukehoban? |
lukehoban
reviewed
Feb 7, 2020
metral
force-pushed
the
metral/oidc
branch
4 times, most recently
from
February 13, 2020 03:27
829d500
to
8c568a8
Compare
Feedback has been addressed. PTAL @lukehoban |
lukehoban
approved these changes
Feb 13, 2020
Refs: - https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_providers_create_oidc_verify-thumbprint.html - https://docs.aws.amazon.com/eks/latest/userguide/enable-iam-roles-for-service-accounts.html - https://aws.amazon.com/blogs/opensource/introducing-fine-grained-iam-roles-service-accounts/ - https://www.pulumi.com/docs/reference/pkg/nodejs/pulumi/aws/eks/#enabling-iam-roles-for-service-accounts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add support to setup OIDC provider for Pod Service Accounts.
Refs:
Related implementations:
Related issues (optional)
Closes #318