-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create EKS cluster & resources with IAM Role Provider #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nitpicks, but overall LGTM.
This is a great PR, thank you!
I'll test this across the full test suite.
Given that this PR is introducing a Thoughts @lukehoban ? |
Thanks for the feedback @metral and @lukehoban If nothing else comes up, I'll push an update this week to address the remaining concerns.
|
I found this issue on one of AWS's repos: aws/containers-roadmap#378 If anyone with more sway could chime in to get the For the time being I refactored the PR to be backwards compatible and added a Example usage: const creationRoleProvider = eks.getRoleProvider("test");
const cluster = new eks.Cluster("test", {
creationRoleProvider: creationRoleProvider,
subnetIds: [...privateSubnets.ids, ...publicSubnets.ids],
nodeSubnetIds: privateSubnets.ids,
vpcId: vpc.id
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Couple of nitpicks - @lukehoban thoughts?
Recent changes LGTM. @lukehoban PTAL Could we also squash down to a single commit? |
Addresses issue: #140