Remove non-existant subnetIds field from TestIgnoringScalingChanges
#1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
flostadler
reviewed
Jan 27, 2025
| @@ -61,5 +61,4 @@ const ngV2 = new eks.NodeGroupV2("ignore-scaling-config-ngv2", { | |||
| operatingSystem: eks.OperatingSystem.AL2023, | |||
| instanceProfile: new aws.iam.InstanceProfile("ignore-scaling-config-ngv2", {role: ngV2Role}), | |||
| ignoreScalingChanges: true, | |||
| subnetIds: eksVpc.privateSubnetIds, | |||
There was a problem hiding this comment.
It’d be great if we could change this to nodeSubnetIds instead. That way those nodes will not consume EIPs
There was a problem hiding this comment.
I can update this PR. Wasn't sure what the best fallback option here was when updating the test.
flostadler
approved these changes
Jan 27, 2025
Merged
|
This PR has been shipped in release v3.8.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes the
TestIgnoringScalingChanges. Previously, the followingObject literal may only specify known properties, and 'subnetIds' does not exist in type 'NodeGroupV2Args'.error occurs when running the upgrade test.Related issues (optional)
Fixes: #1601