chore: remove sdk/nodejs/yarn.lock and restore generate_nodejs target #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Node SDK for the provider does not typically publish a lock file at Pulumi, see for example:
https://github.com/pulumi/pulumi-aws/blob/master/sdk/nodejs/package.json
It is intended to be used as a library with many possible configurations of the host program.
Looks like a yarn.lock may have been committed to pulumi-eks by mistake. Removing.
Does the PR have any schema changes?Looking good! No breaking changes found. |
The intent is to have `generate_nodejs` be separate from `build_nodejs` so that minimal work is done when only re-generating the files is required. Looks like for all languages other than Node this is the case, but a bad Git merge still has the Node target missing.
t0yv0
changed the title
1 task
blampe
approved these changes
Dec 23, 2024
|
This PR has been shipped in release v3.7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove sdk/nodejs/yarn.lock
The Node SDK for the provider does not typically publish a lock file at Pulumi, see for example:
It is intended to be used as a library with many possible configurations of the host program.
Looks like a yarn.lock may have been committed to pulumi-eks by mistake. Removing.
make generate_nodejs
The intent is to have
generate_nodejsbe separate frombuild_nodejsso that minimal work is done when onlyre-generating the files is required.
Looks like for all languages other than Node this is the case, but a bad Git merge still has the Node target missing.