Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix whitespace in version #1554

Merged
merged 1 commit into from
Dec 23, 2024
Merged

chore: fix whitespace in version #1554

merged 1 commit into from
Dec 23, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Dec 23, 2024

This is a second attempt at #1552

This will automatically install pulumictl via go install if one is not found on PATH.

This should help make renovate command to succeed in an environment where pulumictl is not installed in PATH.

If pulumictl is found in PATH the ambient version is used as before.

Placing the comment in the previous version accidentally added whitespace to the version string which caused tests to break:

VERSION_GENERIC ?= $(shell make VERSION_GENERIC=$(PROVIDER_VERSION) version_generic) # comment

IN this PR the comment is on the next line.

@t0yv0 t0yv0 requested review from flostadler and blampe December 23, 2024 17:45
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@t0yv0
Copy link
Member Author

t0yv0 commented Dec 23, 2024

 +  aws:ec2:Eip scalar-types-3 creating (0s) error:   sdk-v2/provider2.go:520: sdk.helper_schema: creating EC2 EIP: operation error EC2: AllocateAddress, https response error StatusCode: 400, RequestID: 53ec38d8-a728-44f4-8613-f6919784552c, api error AddressLimitExceeded: The maximum number of addresses has been reached.: provider=aws@6.59.1

Unrelated to the changes I think.

@t0yv0 t0yv0 merged commit 277dced into master Dec 23, 2024
27 of 34 checks passed
@t0yv0 t0yv0 deleted the t0yv0/fix-whitespace-2 branch December 23, 2024 18:57
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants