Remove ClusterInternal reference in typescript provider #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ClusterInternal type is a internal TS type. When users attempt to transpile their typescript programs to javascript, they'll encounter a symbol not found error, since internal types are not exposed in the type annotations file. ClusterInternal isn't necessary since its used for MLC codegen, so this will not be a breaking change.
Does the PR have any schema changes?Looking good! No breaking changes found. |
rquitales
commented
Jun 21, 2024
| export const kubeconfig2 = cluster2.kubeconfig; | ||
| export const kubeconfig3 = cluster3.kubeconfig; | ||
| export const kubeconfig4 = cluster4.kubeconfig; | ||
| export const kubeconfig1: pulumi.Output<any> = cluster1.kubeconfig; |
There was a problem hiding this comment.
This is necessary due to us linking the eks sdk for testing purposes. Without the type assertions, we'd run into tsc errors like:
index.ts:93:14 - error TS2742: The inferred type of 'kubeconfig1' cannot be named without a reference to '../../nodejs/eks/node_modules/@pulumi/pulumi'. This is likely not portable. A type annotation is necessary.
blampe
approved these changes
Jun 21, 2024
Does the PR have any schema changes?Looking good! No breaking changes found. |
flostadler
pushed a commit
that referenced
this pull request
Sep 4, 2024
### Proposed changes The ClusterInternal type is a internal TS type. When users attempt to transpile their typescript programs to javascript, they'll encounter a symbol not found error, since internal types won't be exposed in the type annotations file. `ClusterInternal` isn't necessary since its used for MLC codegen, so this will not be a breaking change. #### Testing: - Updated existing typescript test to also run the build step ### Related issues (optional) Fixes: #1205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The ClusterInternal type is a internal TS type. When users attempt to transpile their typescript programs to javascript, they'll encounter a symbol not found error, since internal types won't be exposed in the type annotations file.
ClusterInternalisn't necessary since its used for MLC codegen, so this will not be a breaking change.Testing:
Related issues (optional)
Fixes: #1205