Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pulumitest framework for upgrade tests #1177

Merged
merged 6 commits into from
Jun 3, 2024

Conversation

rquitales
Copy link
Member

@rquitales rquitales commented May 31, 2024

Proposed changes

This PR switches the underlying test framework to the newer pulumitest framework which uses Automation API under the hood. This resolves a few pain points related to the existing upgrade tests we have, which are extremely fragile. These changes are:

  • Checking only for replacements, and ignoring diffs. This should help resolve our snapshots constantly being out of date due to changing upstream provider versions, or AMI IDs.
  • Running preview against the cached state to reduce resource usage and speed up the upgrade tests

Related issues (optional)

Related: #927

Fixes: #1145
Fixes: #1174
Fixes: #1155

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@rquitales rquitales force-pushed the rquitales/upgrade-test-new-framework branch from 84701cb to 250a68a Compare May 31, 2024 23:40
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

1 similar comment
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@rquitales rquitales requested a review from flostadler June 3, 2024 16:23
@rquitales rquitales marked this pull request as ready for review June 3, 2024 16:23
@rquitales rquitales changed the title [WIP] Use pulumitest framework for upgrade tests Use pulumitest framework for upgrade tests Jun 3, 2024
examples/subnet-tags/index.ts Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jun 3, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@rquitales rquitales force-pushed the rquitales/upgrade-test-new-framework branch from 45ddb80 to 7589a8e Compare June 3, 2024 19:02
Recording fresh test snapshots for `TestExamplesUpgrades`.
Copy link

github-actions bot commented Jun 3, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@rquitales rquitales merged commit fc50f1c into master Jun 3, 2024
41 checks passed
@rquitales rquitales deleted the rquitales/upgrade-test-new-framework branch June 3, 2024 20:57
flostadler pushed a commit that referenced this pull request Sep 4, 2024
### Proposed changes

This PR switches the underlying test framework to the newer pulumitest
framework which uses Automation API under the hood. This resolves a few
pain points related to the existing upgrade tests we have, which are
extremely fragile. These changes are:

- Checking only for replacements, and ignoring diffs. This should help
resolve our snapshots constantly being out of date due to changing
upstream provider versions, or AMI IDs.
- Running preview against the cached state to reduce resource usage and
speed up the upgrade tests

### Related issues (optional)
Related: #927

Fixes: #1145
Fixes: #1174
Fixes: #1155

---------

Co-authored-by: Pulumi Bot <30351955+pulumi-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants