Enable IMDSv2 for ManagedNodeGroup resources #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquitales
changed the title
Does the PR have any schema changes?Looking good! No breaking changes found. |
rquitales
force-pushed
the
rquitales/enable-imdsv2
branch
from
c0c4e53 to
cebac37
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
blampe
approved these changes
May 17, 2024
| return `#!/bin/bash | ||
| // If the user specifies either kubeletExtraArgs or bootstrapExtraArgs, we need to create a base64 encoded user data script. | ||
| if (args.kubeletExtraArgs || args.bootstrapExtraArgs) { | ||
| const kubeletExtraArgs = args.kubeletExtraArgs ? args.kubeletExtraArgs.split(" ") : []; |
There was a problem hiding this comment.
Unrelated - I think you want to strip this in case you get something like " foo ".
Does the PR have any schema changes?Looking good! No breaking changes found. |
rquitales
force-pushed
the
rquitales/enable-imdsv2
branch
from
96962fc to
c4ef227
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
flostadler
pushed a commit
that referenced
this pull request
Sep 4, 2024
### Proposed changes Exposes a new option for ManagedNodeGroups to enable IMDSv2. This PR is stacked on top of #1131 which allows the creation of a LaunchTemplate to implement these features. Manual testing was done to ensure that we can create a ManagedNodeGroup with IMDSv2 enabled using instructions from: https://stackoverflow.com/questions/64595032/how-to-tell-what-version-of-instance-metadata-serviceimds-ec2-instance-is-usin ### Related issues (optional) Fixes: #682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Exposes a new option for ManagedNodeGroups to enable IMDSv2. This PR is stacked on top of #1131 which allows the creation of a LaunchTemplate to implement these features.
Manual testing was done to ensure that we can create a ManagedNodeGroup with IMDSv2 enabled using instructions from: https://stackoverflow.com/questions/64595032/how-to-tell-what-version-of-instance-metadata-serviceimds-ec2-instance-is-usin
Related issues (optional)
Fixes: #682