Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eks.ManagedNodeGroup: launchTemplate is ignored #1193

Closed
dstockhammer opened this issue Jun 12, 2024 · 2 comments · Fixed by #1196
Closed

eks.ManagedNodeGroup: launchTemplate is ignored #1193

dstockhammer opened this issue Jun 12, 2024 · 2 comments · Fixed by #1196
Assignees
Labels
impact/regression Something that used to work, but is now broken kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@dstockhammer
Copy link

dstockhammer commented Jun 12, 2024

What happened?

It looks like version 2.5.0 introduced a regression that results in the launchTemplate arg to eks.ManagedNodeGroup being ignored. The example below used to work fine up until and including version 2.4.0, but breaks from version 2.5.0 onwards. The launchTemplate arg is ignored and thus removed from the resource as shown in the output.

I believe the regression is caused by a change in #1131; I'll add a comment to that PR.

Example

new eks.ManagedNodeGroup("nodegroup-static", {
  cluster: cluster,
  amiType: "AL2_ARM_64",
  instanceTypes: ["m7g.xlarge"],
  subnetIds: vpc.privateSubnetIds,
  nodeRole: cluster.instanceRoles[0],
  launchTemplate: {  // <-- this is ignored
    id: launchTemplate.id,
    version: pulumi.interpolate`${launchTemplate.latestVersion}`,
  },
});

Output of pulumi about

CLI          
Version      3.119.0
Go Version   go1.22.4
Go Compiler  gc

Plugins
KIND      NAME        VERSION
resource  aws         6.39.1
resource  awsx        2.11.0
resource  docker      4.5.4
resource  docker      3.6.1
resource  eks         2.5.0
resource  kubernetes  4.13.1
language  nodejs      unknown

Dependencies:
NAME                VERSION
@pulumi/awsx        2.11.0
@pulumi/eks         2.5.0
@pulumi/kubernetes  4.13.1
@pulumi/pulumi      3.119.0
@types/node         20.14.2
ts-node             10.9.2
yaml                2.4.5
@pulumi/aws         6.39.1

Additional context

pulumi:pulumi:Stack: (same)
    [urn=urn:pulumi:prod::base::pulumi:pulumi:Stack::base-prod]
        ~ aws:eks/nodeGroup:NodeGroup: (update)
            [id=xxx-prod:nodegroup-static-prod20240304172943231900000001]
            [urn=urn:pulumi:prod::base::eks:index:ManagedNodeGroup$aws:eks/nodeGroup:NodeGroup::nodegroup-static]
            [provider=urn:pulumi:prod::base::pulumi:providers:aws::default_6_39_1::6de6c1e0-804e-479e-b4d1-e06c3f24e08b]
          - launchTemplate: {
              - id     : "lt-redacted"
              - name   : "nodegroup-static-prod20240228152929421500000001"
              - version: "5"
            }
          - launchTemplate: {
              - id     : "lt-redacted"
              - name   : "nodegroup-static-prod20240228152929421500000001"
              - version: "5"
            }

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@dstockhammer dstockhammer added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Jun 12, 2024
@flostadler
Copy link
Contributor

Hey @dstockhammer. Sorry you're running into this. I was able to reproduce it locally and started to work on a fix now.

@flostadler flostadler removed the needs-triage Needs attention from the triage team label Jun 13, 2024
@flostadler flostadler self-assigned this Jun 13, 2024
@flostadler flostadler added the impact/regression Something that used to work, but is now broken label Jun 13, 2024
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jun 13, 2024
@flostadler
Copy link
Contributor

@dstockhammer This is fixed in v2.7.1 now

flostadler added a commit that referenced this issue Sep 4, 2024
In version 2.5.0 custom launch templates got broken. This re-enables
those and adds a regression test.

fixes #1193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/regression Something that used to work, but is now broken kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants