Use subnets instead of subnetMappings on LoadBalancer #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `subnetMappings` property does not correctly handle changes, but the `subnets` property does - and supports the same use cases we need. Workaround for pulumi/pulumi-terraform#45.
mmdriley
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
subnetMappingsproperty does not correctly handle changes, but thesubnetsproperty does - and supports the same use cases we need.Workaround for pulumi/pulumi-terraform#45.
ChangeLog
A change to how load balancers are configured for
cloud.Servicewill mean that applications may see load balancers for non-HTTP services get replaced during updates. This should not cause disruption to applications, but may change the DNS names of the load balancers that services are exposed at.