Skip to content

Commit

Permalink
Fix master build (#829)
Browse files Browse the repository at this point in the history
Looks like the AWS SDK .d.ts file got subtly stricter in a way which TypeScript couldn't infer.  So make the type more explciit.

Also, check in that yarn.lock files so that we build against a consistent set of dependencies.  Ensure that TS builds don't fail when dependency .d.ts files get subtly stricter.
  • Loading branch information
lukehoban authored Nov 26, 2023
1 parent 45e4780 commit 4cac9d0
Show file tree
Hide file tree
Showing 7 changed files with 7,694 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
vendor/
**/Pulumi.*.yaml
**/yarn-error.log
yarn.lock

1,562 changes: 1,562 additions & 0 deletions api/yarn.lock

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion aws/service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ function taskMemoryAndCPUForContainers(defs: aws.ecs.ContainerDefinition[]) {
};
}

function placementConstraintsForHost(host: cloud.HostProperties | undefined) {
function placementConstraintsForHost(host: cloud.HostProperties | undefined): [{type: "memberOf", expression: string}] | undefined {
if (host && host.os) {
return [{
type: "memberOf",
Expand Down
Loading

0 comments on commit 4cac9d0

Please sign in to comment.