Re-implement signedBlobReadUrl with a getAccountSAS call #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellismg
reviewed
May 24, 2019
lukehoban
approved these changes
May 24, 2019
There was a problem hiding this comment.
LGTM.
Do you know if this changes the format of the code URL? If so, that will cause Functions to be updated when this is adopted to point to the new URL (pointing to the same code). I think that's okay - but curious whether that's what we expect to happen or not.
Yes, it will, the URL will be different. Both parameter order and values are different. Note that we are using a SAS on a different level - account not a specific blob. Fine-grained SAS tokens aren't supported. This puts us into a worse position security-wise. Should be fine for accounts auto-created inside our Serverless code, but doesn't feel great anyway. |
CyrusNajmabadi
approved these changes
May 24, 2019
| @@ -40,8 +40,8 @@ export function signedBlobReadUrl(blob: Blob | ZipBlob, account: Account): pulum | |||
| const signatureExpiration = "2100-01-01"; | |||
|
|
|||
| return pulumi.all([account.name, account.primaryConnectionString, blob.storageContainerName, blob.name]).apply( | |||
| ([accountName, connectionString, containerName, blobName]) => | |||
| getAccountSAS({ | |||
| async ([accountName, connectionString, containerName, blobName]) => { | |||
|
Thanks much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #258