Gzip schema and metadata to avoid ballooning memory requirements #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhailshilkov
approved these changes
Aug 26, 2020
| return errors.Wrap(err, "marshaling metadata") | ||
| } | ||
|
|
||
| if err = compressedWriter.Close(); err != nil { |
There was a problem hiding this comment.
What happens if we return the error above? Should we close in defer instead?
There was a problem hiding this comment.
I was initially considering a defered close but a the close actually performs a final flush so we need it to be flushed before writing the serialized content. Also, if we return early, GC should be able to reclaim the buffers created earlier.
| if err != nil { | ||
| return errors.Wrap(err, "marshaling metadata") | ||
| } | ||
| if err = compressedWriter.Close(); err != nil { |
There was a problem hiding this comment.
Does it make sense to make a helper method here somewhere in utils? I don't have a string opinion though.
There was a problem hiding this comment.
We can consider it as a subsequent step if this seems like a sufficient workaround. I have a feeling we might have to do some more maneuvering before a release here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit golang/go#6643 when we compile with the uncompressed literal contents for schema and metadata.
With this the generated files with the literal bytes for schema and metadata are 14MB and 5.5 MB respectively. Last checked, the memory requirement at compile time was around 1 GB.