Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPC with endpoints does not associate the endpoints with subnets #1373

Open
omercnet opened this issue Sep 4, 2024 · 1 comment
Open

VPC with endpoints does not associate the endpoints with subnets #1373

omercnet opened this issue Sep 4, 2024 · 1 comment
Labels
kind/bug Some behavior is incorrect or out of spec vpc Issues related to awsx.ec2.Vpc

Comments

@omercnet
Copy link

omercnet commented Sep 4, 2024

What happened?

created a vpc with an endpoint, the endpoint was created but was not associated with the subnets created by awsx

Example

new awsx.ec2.Vpc(
    args.name,
    {
      enableDnsHostnames: true,
      enableDnsSupport: true,
      vpcEndpointSpecs: [
        { serviceName: `com.amazonaws.${region}.ecr.dkr`, vpcEndpointType: "Interface" }
      ],
    },
    opts,
  );

Output of pulumi about

CLI          
Version      3.129.0
Go Version   go1.22.6
Go Compiler  gc

Plugins
KIND      NAME    VERSION
language  nodejs  unknown

Host     
OS       darwin
Version  14.5
Arch     arm64

Additional context

I'm expecting awsx to attach the private/public subnets it creates to the endpoint
it's impossible to reference those subnets before they're created..

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@omercnet omercnet added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Sep 4, 2024
@t0yv0
Copy link
Member

t0yv0 commented Sep 4, 2024

Thanks for reporting @omercnet ! Looks like we have an omission here, and VPC endpoints will respect manually provided subnets but not an automatically computed subnet layout. My team will have a look as time permits, something along the lines of #1375 can be done to fix (I'm sure there's some more subtleties here).

@t0yv0 t0yv0 added vpc Issues related to awsx.ec2.Vpc and removed needs-triage Needs attention from the triage team labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec vpc Issues related to awsx.ec2.Vpc
Projects
None yet
Development

No branches or pull requests

2 participants